search

deltachat-bot / echo

An echo bot in multiple languages to get you started
The Unlicense
15 stars 4 forks source link

Use deltachat-node-bot-base for nodejs-bot #7

Closed pabzm closed 3 years ago

pabzm commented 4 years ago

We've been working partly in parallel regarding NodeJS. I implemented a small abstraction layer for NodeJS to use as bot library: https://github.com/deltachat-bot/deltachat-node-bot-base

I suggest to use that library for the NodeJS-bot in order to avoid repetition. The README includes example code that explains how to use it.

@Simon-Laux If you agree but don't want to do it yourself, let me know and I'll take it into my hands.

Simon-Laux commented 4 years ago

I would make a separate version that uses the abstraction layer. Also I don't quite see the need for the bot base as long as it doesn't have more convenience features like an easy way to register command.. Anyways I'd like to have both examples, also for python, one for each variant. The echo example here is cheap so why not have multiple of them?

Simon-Laux commented 4 years ago

Also your bot base is a bit oversimplified IMO, I would aim for an api like discord.js has: https://discordjs.guide/command-handling Also forcing people to use "config" for configuration is not the best thing to do, recommend that module in the example - sure that's cool, but forcing it onto everyone that uses the botbase is not cool IMHO, especially when you want that even professionals can use that, not only programming beginners.

pabzm commented 4 years ago

I'm not interested in being lectured about what's cool, and what suits "professionals", so I'll rather close this.