cmdeploy run should refuse to run if iroh subdomain isn't set

deltachat / chatmail

chatmail service deployment scripts and docs

https://delta.chat/en/2023-12-13-chatmail

MIT License

134 stars 13 forks source link

Closed missytake closed 2 hours ago

missytake commented 2 hours ago

expected behavior: instead of failing at the acmetool step which could affect the letsencrypt rate limit, if I have a necessary subdomain like iroh.$mail_domain not set, it should refuse to run.
actual behavior: it just runs. actually not even cmdeploy dns warns us about the missing subdomain atm.

missytake commented 2 hours ago

Ah, we have set iroh_relay in chatmail.ini, that's why it didn't refuse to run. The better solution is to not try to get a cert in this case.