title bar on "Welcome Screen" - Githubissues

deltachat / deltachat-android

Email-based instant messaging for Android.

GNU General Public License v3.0

1.15k stars 149 forks source link

title bar on "Welcome Screen" #2682

Closed r10s closed 1 year ago

r10s commented 1 year ago

after the refactoring of https://github.com/deltachat/deltachat-android/pull/2671, there is an unexpected title bar on the welcome screen reading "Delta Chat"

while we should check, why this happens and if there is an underlying bug, we may decide to keep the title bar:

we are using a similar title bar on ios already - the titles can read "Welcome to Delta Chat" resp. "Add Account" later
we can have a real back button in case of "Add Accout"
we can have a kebab menu; this may be useful at some later point when it comes to instant-accounts and we do not have lots of buttons directly on the screen

r10s commented 1 year ago

did a fix to create that state from before at https://github.com/deltachat/deltachat-android/pull/2684 - it is better to decide some title bar refactoring when it is actually needed