search

deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.09k stars 144 forks source link

auto-generated RPC bindings #3097

Closed adbenitez closed 2 days ago

adbenitez commented 3 months ago
github-actions[bot] commented 3 months ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] commented 3 months ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

r10s commented 3 months ago

thanks for making this possible! this will make things much easier in the future!

however, for the ongoing release, this is a too large and massive change for 1.46.0 to 1.46.1+ - even if most things are auto-generated, i do not want to risk getting issues by that or dive into this topic completely, which is needed for review.

therefore, for the two missing jsonrpc for the peer-to-peer, we should add them by hand as before, i think, they do not even have parameters, so that should be easy.

when 1.46 is finally in all stores and things are settled so far we can finally go for this PR

link2xt commented 2 months ago

Where is the generator itself? And the docs regarding regenerating when core is updated are needed.

adbenitez commented 2 months ago

Where is the generator itself?

it is closed source with a paid license subscription

adbenitez commented 2 months ago

Where is the generator itself?

published it here: https://github.com/deltachat/dcrpcgen

github-actions[bot] commented 2 months ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 2 months ago

I rebased the branch on main but now for some reason some changes from main appear as new changes :(

github-actions[bot] commented 2 months ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

link2xt commented 2 months ago

I rebased the branch on main but now for some reason some changes from main appear as new changes :(

You probably need to git rebase -i origin/main and drop everything that is not related to this PR.

adbenitez commented 2 days ago

this needs more work/fixes it was not working as expected, with all changes in the code structure in the meanwhile, it is better to re-do/revive later