deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.07k stars 145 forks source link

cancel muting should not exit select-mode #3124

Closed r10s closed 1 month ago

r10s commented 1 month ago

exiting 'select mode' is unexpected when hitting 'cancel' - the user may still want to do other things with the selection.

this makes the 'mute' behavior consisten with other cases showing a dialog, eg. 'delete'

github-actions[bot] commented 1 month ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

r10s commented 1 month ago

yeah, came over that while searching for a "Mark All As Read" :)

let's wait for merging until #3122 is merged ... rebasing this PR seems easier :)

github-actions[bot] commented 1 month ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 1 month ago

it seems no rebasing is needed since the file was just moved but there is no content conflict :thinking:

r10s commented 1 month ago

github said there's a merge conflict, rebase then did not need interaction .... some say so and some say so :)