stop using jcenter - Githubissues

deltachat / deltachat-android

Email-based instant messaging for Android.

GNU General Public License v3.0

1.1k stars 144 forks source link

stop using jcenter #3215

Closed adbenitez closed 4 weeks ago

adbenitez commented 1 month ago

close #1791

Migration plan:

[x] upgrade com.google.android.exoplayer:exoplayer-core/ui to recent version
[x] upgrade com.journeyapps:zxing-android-embedded to more recent version ⚠️REQUIRES MinSdk 19+
[x] remove unused dependency 'mobi.upod:time-duration-picker
[x] get com.amulyakhare:com.amulyakhare.textdrawable from JitPack.io instead of jcenter
[x] include com.codewaves.stickyheadergrid:stickyheadergrid in our code (upstream is unmantained)
[x] declare recent version of dep relinker to avoid de.cketti.safecontentresolver:safe-content-resolver-v14 depending on old relinker version

Hocuri commented 1 month ago

So, this means that, since we're including the binary blob now, we just can't publish any more F-Droid versions until either:

We manage to get the source code of the old dependency versions, include it in the repo, and get gradle to compile them together with our own source code
Or we switch to newer versions that are available via Maven Central, dropping support for some older Android versions?

adbenitez commented 1 month ago

good point, some of the jars have the .java files but others are compiled .class, so this is not the way to go to solve the problem with fdroid!?

we will have to go the migration route :(

Hocuri commented 1 month ago

For Exoplayer, there is a migration guide https://developer.android.com/media/media3/exoplayer/migration-guide in case this helps
For textdrawable, simply replacing implementation 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.1' with implementation 'com.github.amulyakhare:TextDrawable:558677ea31' seems to work (i.e. getting it from JitPack.io instead of jcenter)
JitPack unfortunately can't build StickyHeaderGrid because it depends on other jcenter dependencies. Maybe it's enough to fork Sticky-Header-Grid and add mavenCentral() to build.gradle, idk.

adbenitez commented 1 month ago

with implementation 'com.github.amulyakhare:TextDrawable:558677ea31' seems to work (i.e. getting it from JitPack.io instead of jcenter)

this is a rather fragile solution, tried forking the repo and currently jitpack.io doesn't manage to build the repo anymore (see https://jitpack.io/#deltachat/TextDrawable) but for now we can go with that one until it breaks again, anyway I will keep the fork around in the org just in case it gets deleted etc.

github-actions[bot] commented 1 month ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 1 month ago

@r10s did something to lower minSdk to 19, that is the minimum supported by com.journeyapps:zxing-android-embedded

cc @link2xt

github-actions[bot] commented 1 month ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk