search

deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.1k stars 144 forks source link

stop 'encrypted database' experiment #3240

Closed r10s closed 2 weeks ago

r10s commented 3 weeks ago

this PR removes options to create encrypted database. existing encrypted databases will continue working for now.

the 'encrypted database' experiment started some years ago was never finished and already stopped working partly, eg. importing backups as encrypted accounts stopped working some years ago for newer android.

in the light of Signal's "encryption key flaw", but also recent issues with worsending core things in Delta Chat, it seems wise to concentrate on the core things ("you have one job!"), and not on side topics comparable few persons are interested in.

also, it will become harder to maintain that path on upcoming api changes, leaving the database open as opening is slow is needed but will become harder, this will make notifications tricy, may need additional effort to run in background etc.

all that is doable, however, it will remove resources from far more important parts, dangerously up to a level that breaks the app - a focus is limited.

also, no one really complained as it is already partly not-working, it was never working on desktop (where it would make much more sense), removal on iOS was flawless, see https://github.com/deltachat/deltachat-ios/pull/2011

tl;dr: better leave the protection up to the operating system and concentrate on other things.

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

r10s commented 3 weeks ago

counterpart for adapting FAQ: https://github.com/deltachat/deltachat-pages/pull/946

link2xt commented 3 weeks ago

This does not seem to remove much code and I don't understand what does it make easier.

adbenitez commented 3 weeks ago

This does not seem to remove much code and I don't understand what does it make easier.

just remove the "encrypt database" checkbox from advanced account creation

r10s commented 2 weeks ago

it removes the need to think about, deal with and maintain a whole set of states and bugs. esp. on api updates and changes in related areas