search

deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.1k stars 144 forks source link

improve nickname dialog #3254

Closed r10s closed 3 weeks ago

r10s commented 3 weeks ago

this PR improves the "Edit Name" dialog.

inspired by this forum post - indeed, there was just nothing. thanks a lot for the hints!

after some internal discussions, we went for placeholder+description. using radio buttons looks to complex for a comparable easy task, also in relation to comparable dialogs in-app and in other apps.

moreover, the PR uses the string "Edit Name" instead of "Edit" in the menu. i was thinking about renaming that even to "Nickname", however, that may be confusing on other levels, we can always iterate.

finally, the dialog is no longer closed by one wrong tap, avoiding potential loss of typed names.

once this is merged, desktop and iOS can pick up these strings.

before / after

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk