search

deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.15k stars 148 forks source link

Don't show "0%" at the beginning when being added as second device #3409

Closed Hocuri closed 2 weeks ago

Hocuri commented 2 weeks ago

Mitigation for https://github.com/deltachat/deltachat-android/issues/3392, follow-up for https://github.com/deltachat/deltachat-android/pull/3337.

When creating a chatmail account, when logging in to an existing email account, and when importing a backup from the Welcome Activity, we're still showing "0%" even after this PR. So, an alternative to this PR would be to make percent > 0 ? String.format(Util.getLocale(), " %d%%", percent) : ""; into a function and call it from all these places, too, and never show "0%" anywhere ever again.

github-actions[bot] commented 2 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

Hocuri commented 2 weeks ago

Merging since it's a mitigation for a bug that's possibly a regression