deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.15k stars 149 forks source link

fix: Accept the deprecated 3 as an alias for 2 #3410

Closed Hocuri closed 3 weeks ago

Hocuri commented 3 weeks ago

fix #3408 by automatically changing a 3 to 2.

3 is a deprecated alias for 2, so all UIs now need to handle both values. I think it wasn't a good idea to deprecate 3 in the first place, but it's not worth it going back now.

I tested this PR like this:

r10s commented 3 weeks ago

did a PR fixing the documentation for the CFFI as well, https://github.com/deltachat/deltachat-core-rust/pull/6176

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

r10s commented 3 weeks ago

so that we can sleep better, i created #3412 :)

r10s commented 3 weeks ago

I think it wasn't a good idea to deprecate 3 in the first place, but it's not worth it going back now.

i agree, lesson learned. we should try harder to keep things stable for UI. we had a similar hickup with DC_QR_BACKUP2 recently.

Hocuri commented 3 weeks ago

Merging since it fixes a crash