remove old emojis - Githubissues

deltachat / deltachat-android

Email-based instant messaging for Android.

GNU General Public License v3.0

1.15k stars 149 forks source link

remove old emojis #3411

Closed adbenitez closed 2 weeks ago

adbenitez commented 3 weeks ago

use modern emoji2-emojipicker instead (already in use by reactions picker)

close #3399 close #1993

To Do:

[x] remove old emoji images assets
[x] remove "use system emojis" preference
[x] use emoji2-emojipicker instead of old emoji picker
[x] implement on-click event in new emoji picker
[x] fix emoji text views
[x] delete old emoji code
[x] fix emoji color for reaction pills
[x] enlarge font size when text is only a few emojis

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 3 weeks ago

caveats:

after a lot of searching for solutions I didn't find any proper&easy way to detect emojis in text in java for the font size scaling effect, so if you send a single emoji the message will look the same as any other message, hopefully core could help with this in the future
the emoji picker doesn't have a delete button, this could be added eventually when we add a row to switch between emojis and sticker picker, that is how it is in whatsapp

github-actions[bot] commented 3 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

link2xt commented 2 weeks ago

Desktop uses code from message parser: https://github.com/deltachat/message-parser/blob/13efc9be4f6363f02104d88431f6685e6318e29e/src/parser/is_emoji.rs#L143

https://github.com/deltachat/deltachat-desktop/blob/cbb27a89fe91757bd1b7d634ead1fac7ea28d01a/packages/frontend/src/components/conversations/emoji.ts#L57

adbenitez commented 2 weeks ago

ok, I added the emoji scaling feature using a regex based on data from: https://util.unicode.org/UnicodeJsps/list-unicodeset.jsp?a=%5B%3AEmoji%3DYes%3A%5D&g=&i=

it is not perfect, still some newer emojis seems to not match it, but it is even better than the existing emoji detection we had which would also show the same emojis small

I think a better regex should be provided by some core API

github-actions[bot] commented 2 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

r10s commented 2 weeks ago

Minus 2.6MB, plus fixing an issue 🎉!

yeah, i was also curious at the same time as you :) - can confirm the 2.6MB smaller APK, excellent!

r10s commented 2 weeks ago

ftr, this is how it looks like on and old android7, where the system emoji were still in "blob style" - one can see quite nicely there, how the gaps are filled by he new-style-emoji - what a nice improvement, compared to having just nothing before:

github-actions[bot] commented 2 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk