deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.15k stars 148 forks source link

don't increase reaction selector's font size according to system #3419

Closed adbenitez closed 1 week ago

adbenitez commented 1 week ago

also avoid moving the selector horizontally out of screen

close #3291

github-actions[bot] commented 1 week ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 1 week ago

It's not working when the screen is actually small or when the display size is increased in the settings (only when the font size is increased in the settings). Nonetheless, it's an improvement to how it is today.

mmmh weird, it should span to the full screen size but it is smaller for you, I tested with both, font and screen amplification and it looked fine for me :(

could you try with system emojis?

Hocuri commented 1 week ago

could you try with system emojis?

I tried with current main (which has both this PR and https://github.com/deltachat/deltachat-android/pull/3411/ merged), still too big

r10s commented 1 week ago

seem the screen of @Hocuri is even smaller than the one in the original post - see the whitespace between "1" and "reply".

as this is popping up constantly, i fear, we need to be a little more adaptive here. maybe the following is good enough:

if screenWidth < N {
  set laugh-emoji and sad-emoji to View.GONE - maybe even heart-emoji
}

or

if screenWidth < N {
  use half width/height for emoji, or calculate emojiWidth/Height by screenWidth - that'd be harder to tap, but that's it then 
}

we were considering to hide sad-emoji alltogether, but that may not fix the issue accodingly, also for consistency with desktop (and also iOS has these emojis prefilled in the selector) that would not be a very nice solution

adbenitez commented 1 week ago

notice that the selector looks fine in hocuri is phone, it is about the case when in such small screen you also use the screen scaling/augmentation which is not what someone with such small screen would do,

a more generic solution could be to use a scrollbar inside the bubble to catch such extreme cases at least without errors