deltachat / deltachat-android

Email-based instant messaging for Android.
GNU General Public License v3.0
1.15k stars 149 forks source link

change proxy protocol label position #3422

Closed adbenitez closed 1 week ago

adbenitez commented 2 weeks ago

close #3421

github-actions[bot] commented 2 weeks ago

To test the changes in this pull request, install this apk: 📦 app-preview.apk

adbenitez commented 1 week ago

when on that, i'd use the same padding for checkmark and status as well:

* the checkmark does not belong to status nor protocol, it is an symbol on its own

the padding is used because the label has the line background, the actual separation between the items is the same with android:layout_marginEnd="5dp"

if you add such padding to the checkmark and status the checkmark will look closer to the protocol label actually since there will be 10dp of empty space between the checkmark and the status and only 5dp of empty space between checkmark and protocol label

adbenitez commented 1 week ago
  • the checkmark does not belong to status nor protocol, it is an symbol on its own

that is why it looked better at the start, yeah we will likely need to further improve this layout, ideally the protocol label would go up to the server title where it fits more together, and the subtitle would be the availability of the proxy or ping latency (that is how it is in Telegram) but since we don't have that, it was looking too empty with smaller items for not selected proxy and bigger item for selected proxy, that is why I put the label in the subtitle