Can't share with pattern set

deltachat / deltachat-android

Email-based instant messaging for Android.

GNU General Public License v3.0

1.12k stars 147 forks source link

Can't share with pattern set #464

Closed adbenitez closed 5 years ago

adbenitez commented 5 years ago

I have set the Screen lock option to unlock Delta Chat with a pattern, but with this option set, sharing a file with Delta Chat doesn't work

Platform (android/blackberry/anbox): Android 6.0
Device: BLU
Delta Chat Version: 0.98.2
Steps to reproduce the problem: Go to Settings/Privacy and enable "Screen Lock" switch, close the app go to your file manager and try to share a file, select Delta Chat, you will prompted to enter your pattern, nothing happens, you get back to your file manager.

Boehrsi commented 5 years ago

Will look into that one.

HidingCherry commented 5 years ago

Nearly the same problem for PIN and on newer version. (Mostly copied from adbenitez and changed the different things.)

Platform (android/blackberry/anbox): Android 8.1 (omniROM) Device: suzu (Sony Xperia X) Delta Chat Version: 0.100.0 Steps to reproduce the problem: Go to Settings/Privacy and enable "Screen Lock" switch, close the app go to your file manager and try to share a file, select Delta Chat, you will prompted to enter your PIN, enter the PIN, then the prompt to enter the PIN will reappear again, the same always happens if I enter the PIN.

Boehrsi commented 5 years ago

Yep, this issue shouldn't be related to the given Android version. The sharing stuff needs to be aware of the screen lock feature, which is currently missing and I hope it will be fixed next week.

Boehrsi commented 5 years ago

Fixed by:

Allowing the ShareActivity to exist in the stack history
Moved the deletion of unneeded content from onPause to onDestroy, to allow the ShareActivity to exist in the background (required as soon as the ScreenLockActivity takes over the screen)

r10s commented 5 years ago

closed by https://github.com/deltachat/deltachat-android/pull/703