search

deltachat / deltachat-core-rust

Delta Chat Rust Core library, used by Android/iOS/desktop apps, bindings and bots 📧
https://delta.chat/en/contribute
Other
683 stars 87 forks source link

Implement API to get UI recommendation for autocrypt #1125

Closed link2xt closed 4 years ago

link2xt commented 4 years ago

Currently Autocrypt decision is made completely automatically. According to Autocrypt specification users should be able to override the decision unless UI recommendation is "disable".

This is needed because currently it is impossible to enable encryption in a group with inactive users without deleting them from the chat if encryption is not already enabled, and it is impossible to disable encryption in a chat once the first encryption message is sent, because replies to encrypted messages are always encrypted.

New API is needed: a call to get UI recommendation and a call to send a message with encryption decision specified explicitly.

r10s commented 4 years ago

According to Autocrypt specification users should be able to override the decision unless UI recommendation is "disable".

iirc, it is a SHOULD, so, we do not break things.

however, as figured out on 36c3, this is nothing we can go for the next time, UI adaptions and other considerations are needed etc. maybe we can implemented the fix we talked about.

therefore i would suggest to close the issue for now and reopen it when we come back to it.

Jikstra commented 4 years ago

@r10s why can't we go for it now?

link2xt commented 4 years ago

@Jikstra Nobody is working on it ATM and we don't want to have a wishlist in GH issues. We can reopen it later when we start working on it.

r10s commented 4 years ago

yip, as @link2xt pointed out, there are just other things to do the next time. also, ux wise, it is not that simple and needs some broader discussion that should also keep the verified groups and other things in mind. however, i would not like to enter this discussion now, there is already tons of things to do :)