search

deltachat / deltachat-core-rust

Delta Chat Rust Core library, used by Android/iOS/desktop apps, bindings and bots 📧
https://delta.chat/en/contribute
Other
658 stars 84 forks source link

resending a webxdc causes all sent info messages to be shown to the receiver #3251

Closed adbenitez closed 2 years ago

adbenitez commented 2 years ago

with https://github.com/deltachat/deltachat-core-rust/pull/3238 it is possible to resend webxdc messages, the issue is that in the receiver side, all info messages generated by old state updates are shown when the webxdc instance is received, instead, it should work like when info-updates are sent in draft mode, not showing them when the message is sent

r10s commented 2 years ago

i just had a rough look: in draft-mode, info-messages are explictly set to None, not written to the database and not sent out therefore.

maybe we should handle this state differently at a later point so that both, drafts and resends do the same and do not display the info-messages. that might also be more straight forward as the app-developer would see his update as sent (including info, even if that info is not added to the ui)

but i like to do that after https://github.com/deltachat/deltachat-core-rust/pull/3238 is merged, it affects only webxdc and not resending and would make #3238 harder to review.