deltachat / deltachat-core-rust

Delta Chat Rust Core library, used by Android/iOS/desktop apps, bindings and bots 📧
https://delta.chat/en/contribute
Other
658 stars 83 forks source link

partial download of webxdc triggering msgs-changed event with wrong trash-chat id #4580

Closed adbenitez closed 1 year ago

adbenitez commented 1 year ago

so I was testing why on android when you click the "download" button of a big message that is a message update, it doesn't refresh the message area and the UI keeps displaying the "downloading..."

in fact there is a core bug it seems, this are the "chatId" in data1 for the "msgs changed events triggered for a status update incomplete download:

07-25 22:30:29.142  7508  7508 W  : MSGS CHANGED: 502
07-25 22:30:29.558  7508  7508 W  : MSGS CHANGED: 3

as you can see on the click on the "download" button it first triggers the change to "downloading..." state but then the next "msgs chaged" event notifying the finishing of the download, has in data1 chatId == 3 == DC_CHAT_ID_TRASH instead of reporting the chat where the message was

link2xt commented 1 year ago

Made a fix: #4581