search

deltachat / deltachat-core-rust

Delta Chat Rust Core library, used by Android/iOS/desktop apps, bindings and bots 📧
https://delta.chat/en/contribute
Other
682 stars 87 forks source link

not possible to send webxdc app staged in draft with JSON-RPC API #4643

Open adbenitez opened 1 year ago

adbenitez commented 1 year ago

it is common need to stag a webxdc app to setup its state before sending it, that is set the app as draft (like on DC android), but with current JSON-RPC API it is not possible to send the staged draft, or send a new message with status updates set

Septias commented 1 year ago

Why did you add the jsonrpc label if you want to have a more powerful webxdc api? I guess you are talking about sending staged webxdcs from within other webxdcs?

hpk42 commented 1 year ago

could you close this issue and, if needed, open a new one, at best after a discussion with Bjoern or so, and try to phrase it as an actionable item for core? I am btw not sure i understand precisely -- staging in android including creating some app-updates works but that's probably not what you mean?

r10s commented 1 year ago

imu, the issue is, that jsonrpc does not allow to stage+prepare webxdc apps in draft mode (so, desktop cannot implement stage+prepare)

otoh, stage+prepare webxdc apps is possible in cffi (android/ios use cffi and allow stage+prepare therefore)

so, the actionable item is to modify the jsonrpc so that stage+prepare webxdc apps is possible.

i also had to re-read several times - the issue makes sense only if you read the tag as well - in general, i think, issue texts should be understandable by not reading tags or headlines (which should only summarise and organise) - but i am sure, i am am also sometimes failing on that :)

adbenitez commented 1 year ago

thanks @r10s, yes that was the intention, I edited the post, the issue is I made a typo and said "webxdc api" instead of "jsonrpc api" that is why everyone else was confused :sweat_smile:

this issue is an important stepping stone so DC Desktop can add staging/drafting of webxdc apps before sending them

hpk42 commented 1 year ago

thanks @r10s, yes that was the intention, I edited the post, the issue is I made a typo and said "webxdc api" instead of "jsonrpc api" that is why everyone else was confused 😅

this issue is an important stepping stone so DC Desktop can add staging/drafting of webxdc apps before sending them

you still didn't address my comment, though -- which would mean maybe something like "implement json-rpc support for staging draft webxdc apps" -- linking the existing CFFI functions in the description.

There is another related practise i discussed with link2xt and r10s yesterday: core API issues and PRs should have a corresponding UI PR and not be done and discussed independently from usage. So if there is no ongoing work/PR to use a new jsonrpc-api i suggest to close this issue here.

Septias commented 1 year ago

closing because there does not seem to be a need for this. Feel free to reopen if I'm wrong @adbenitez

link2xt commented 1 year ago

There is a corresponding desktop issue: https://github.com/deltachat/deltachat-desktop/issues/2722

New deltachat-rpc-client bindings are now uploaded to PyPI #4523. New JSON-RPC bindings are no longer experimental, e.g. localbot@testrun.org and matterbridge are using it, so bots will also need this if they want to prepare .xdc before sending.