deltachat / deltachat-core-rust

Delta Chat Rust Core library, used by Android/iOS/desktop apps, bindings and bots 📧
https://delta.chat/en/contribute
Other
659 stars 85 forks source link

avatar is no longer synchronized across devices #5681

Closed r10s closed 1 week ago

r10s commented 3 months ago

when doing a QR code scan or tapping an invite link, on the currently released versions (1.46), using recent core, the avatars are not picked up from all devices.

i think, this is a new bug, i am pretty sure this worked in the past. the bug might be introduced by https://github.com/deltachat/deltachat-core-rust/pull/5363 (cc @iequidoo)

the bug results in confusing UX - having different avatars for the same chat is pretty bad, esp. as we're announcing the multi-device feature quite broadly meanwhile :)

to reproduce:

now Alice has a chat with Bob, including the avatar on deltachat-android.

when Alice now opens her deltachat-desktop, Alice has a chat with Bob, the avatar on deltachat-desktop is missing.

iequidoo commented 3 months ago

For some reason i couldn't reproduce this, i tried Gmail and a chatmail (nine) for Alice. Bob was using a chatmail in both cases. It looks like your Alice on Desktop didn't see the vc-request-with-auth message for some reason because the Bob's avatar is passed in it.

EDIT: Btw, the bug description is very similar to the previously fixed #5354, there it was also DC Desktop not showing the Bob's avatar. Note that the bug was fixed on the Bob's side, so Bob should be up-to-date. We can also do an Alice-side w/a so that vc-request isn't deleted after processing, but seems it isn't worth the effort.

iequidoo commented 1 week ago

Let's close this as a duplicate of #5354 for now