search

deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
940 stars 167 forks source link

Emoji sorted inmediately in "Frequently Used" category #1177

Closed adbenitez closed 4 years ago

adbenitez commented 4 years ago

When user click an emoji in the "Frequently Used" category it is re-sorted immediately, which causes some troubles when user clicks several times an emoji and then it change position with another emoji and a wrong emoji is inserted by accident, list should be updated when opening the emoji popup menu again, once open keep current emojis in current position (as done in DC-Android currently)

adbenitez commented 4 years ago

(please note this reports are due I am testing Delta Chat Desktop, I'm NOT requesting to tackle ASAP)

Simon-Laux commented 4 years ago

We use a library for the emoji picker. So we need to ask https://github.com/missive/emoji-mart for a solve.

Jikstra commented 4 years ago

Or hack around the library ^^

Simon-Laux commented 4 years ago

Or hack around the library ^^

Not in this case, its too deep in it.. maybe to solve #1181, but not for this one.

Simon-Laux commented 4 years ago

looks this isue was already fixed in emoji mart so we just need to update the dependency https://github.com/missive/emoji-mart/issues/366 https://github.com/missive/emoji-mart/pull/417

Simon-Laux commented 4 years ago

but the version we need isn't released yet, so we need to wait.

Jikstra commented 4 years ago

Can we depend on the git of emoji mart and pin to a specific commit?

Simon-Laux commented 4 years ago

Looks like there were already a few new versions, but they are not documented in the release section only as tags and in the changelog. So we can probably upgrade to version 3, but it has some breaking changes so we need to keep an eye on https://github.com/missive/emoji-mart/blob/master/CHANGELOG.md