deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
934 stars 166 forks source link

[Discussion] Don't quoute on double click? #2226

Closed Simon-Laux closed 3 years ago

Simon-Laux commented 3 years ago

Double click is normally selecting a word, so it conflicts with the "double click to quote feature". I suggest putting double click to quote behind an optional setting or removing it completely.

What are your opinions?

CC @Jikstra @nicodh @link2xt @Hocuri @hpk42 @r10s

link2xt commented 3 years ago

I don't support having more configuration options, it's harder to maintain, harder to test all the interactions between options, harder to have options in sync between devices etc.

I think I never used double click to quote in DC, always select Reply in the menu. I'm ok with just removing this "double click to quote", but maybe we need a small button somewhere within the bubble or outside to replace it for when right-clicking is inconvenient (touchpads and similar devices)? I think you did some experimental code/mockups for this.

Simon-Laux commented 3 years ago

I think you did some experimental code/mockups for this.

I did but @Jikstra didn't like it and pushed the double click thing instead. I agreed at the time, because I didn't have a strong opinion on it.

Hocuri commented 3 years ago

I'd be in favor of removing "double-click-to-quote", but putting an icon for quoting in the top right corner (Discord and Slack let these icons only appear when you hover your mouse over the message, but I don't mind, they could also just be always there)

Hocuri commented 3 years ago

I don't support having more configuration options, it's harder to maintain, harder to test all the interactions between options, harder to have options in sync between devices etc.

+1

r10s commented 3 years ago

+1 for not adding configuration options; we should definitely not do that for this kind of things.

for the double-click: it also conflicts with messages containing an image/video/etc., it confused me several times, enlarging an image where i want to answer (seems i was very used to double click).

so, maybe the double-click is comfortable, but if you are used to that, it stands in the way of many other things. and you have to learn an alternative anyway.

so, even when not doing other things, just relying on the context menu for replies is probably better ux.

up to some point, we had this "button appearing on hovering messages", tbh, i did no like that implementation too much, the button was too big and added too much noise, too much flickering (i know, telegram does it that way).
iirc, we had the rough idea to use this button-appears-on-hover, but tuned down, showing the button inside the bubble, maybe bottom-left-aligned (where always is some space because of the date/on the right) or top-right where @Hocuri suggested (there is no space in one-to-ones, so that might be trickier, also i find that less logical, but well) - maybe these are the mockups @link2xt talked about? there were at least some screenshot somewhere.

Simon-Laux commented 3 years ago

I would not add buttons, they are difficult to align right (with all types of messages), if there are problems on touch screens we could define that long press is equal to right click.

r10s commented 3 years ago

I would not add buttons, they are difficult to align right (with all types of messages)

what about adding the buttons left of the delivery/date area - as that area is present for all messages anyway, that should be easier to add generically for all message types. i would still showing them on hover-only, however. sth. like that:

Screen Shot 2021-04-18 at 21 06 00

but as a first step, only relying on context menu is probably also okay.

if there are problems on touch screens we could define that long press is equal to right click.

i did not use much touch-screens on desktop yet, but i would expect that this is solved somehow by the os, a quick search also points in that direction: https://answers.microsoft.com/en-us/education_ms/forum/edu_win10-edu_ink/right-click-in-windows-10-using-touch-screen/1de53031-c561-4110-a85d-d60e5edbbbb8 - so maybe, this point is nothing to worry about much.

Simon-Laux commented 3 years ago

as that area is present for all messages anyway

two examples where additional styling would be needed: stickers, images/videos

up to some point, we had this "button appearing on hovering messages", tbh, i did no like that implementation too much, the button was too big and added too much noise, too much flickering (i know, telegram does it that way)

maybe telegram on mac, telegram on linux doesn't have any buttons on messages at all, only right-click

r10s commented 3 years ago

two examples where additional styling would be needed: stickers, images/videos

don't they have date/delivery currently? so just using the same font/colors/etc. sounds doable with not too much effort, if one wants to go that way. however, of course, i do not know about javascript/node pitfalls that may be there, it was just a suggestion, how things could be easier :)

telegram on mac, telegram on linux doesn't have any buttons on messages at all, only right-click

ah, i see - i thought these big buttons outside the message bubble (that i do not like) came from there :) otoh signal, discord, slack and most email programs have dedicated reply/forward buttons. having email-compat in mind, reply/forward may become more important for us as well at some point.

however, as said, context-menu-only is okay for me as well. and maybe everyone is just satisfied with that :)

Jikstra commented 3 years ago

up to some point, we had this "button appearing on hovering messages", tbh, i did no like that implementation too much, the button was too big and added too much noise, too much flickering (i know, telegram does it that way).

+1 I don't like flickering things on hover.

I'm fine with removing double click to reply.

Simon-Laux commented 3 years ago

So the conclusion is that we remove the double click to reply functionality.