search

deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
919 stars 166 forks source link

missing vertical space between webxdc start-button and message-text #2762

Closed r10s closed 2 years ago

r10s commented 2 years ago

between the webxdc-start-button and the messages text, there should be some vertical spacing.

i suggest to use the same amount of space as between webxdc-name/-summary and webxdc-start-button; however, the additional space must not be applied if there is no messages-text, in this case, things are already fine.

Screen Shot 2022-05-17 at 18 44 08

red: there is some space missing

  as a side-effect, this may also fix the floating of big emojis into the button as reported in some other channel: image_2022-05-17_02-16-02 this is a cool-looking bug, btw :)

gcamach0 commented 2 years ago

Hi @r10s, im looking to make my first open source contribution and i was wondering if there's no one else working on this if I could give it a try

r10s commented 2 years ago

hi @gcamach0, first of all: welcome aboard!

i do not think, someone is working on that just now, so, it would be great if you can give it a try!

gcamach0 commented 2 years ago

Hey guys! I just added a pr #2783 for this issue. I would really appreciate it if you could take a look at it. I will keep an eye out for any comment you may have. I also saw that a check failed because I didn't update the changelog. I was wondering if it is something that I have to do at once or should I wait to see what results from the review?