deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
939 stars 166 forks source link

allow accessing webxdc source #3007

Closed r10s closed 1 year ago

r10s commented 1 year ago

if source_code_url is not empty, that should be made available to the user in an unobtrusive way (not taking space in the app window nor adding things there). the already existing menu seems to be an ideal place for that, although there seem to be some implementation issues iirc.

cmp. https://github.com/deltachat/deltachat-android/pull/2301, https://github.com/deltachat/deltachat-ios/pull/1593

Simon-Laux commented 1 year ago

This is the case already, just not on macOS: image

there are questions about the macOS menu, as there can only be one menu on macOS, while on linux and windows there can be a different menu for each window.

r10s commented 1 year ago

ahh, that one, i remember. shame on electron that it is not handled properly - 25 years ago this was already solved ...

iirc, some month ago, we found some workaround at https://github.com/electron/electron/issues/4327 , but yes, it is probably not the most important thing then.

r10s commented 1 year ago

was just searching for source code on desktop/mac again while adding CryptoText to xdcget - then i remembered it is missing on macos 😅 i'd consider this as a bug :)