deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
898 stars 166 forks source link

Map doesn't open #3858

Closed missytake closed 2 months ago

missytake commented 2 months ago
missytake commented 2 months ago

If I start deltachat-desktop with npm run start, it works.

missytake commented 2 months ago

The path doesn't work:

$ file /opt/DeltaChat/resources/app.asar
/opt/DeltaChat/resources/app.asar: data

There is /opt/DeltaChat/resources/app.asar.unpacked/, but it just contains:

.
└── node_modules
    └── @deltachat
        └── stdio-rpc-server-linux-x64
            ├── deltachat-rpc-server
            └── package.json

3 directories, 2 files

In general the file doesn't seem to be shipped, $ find /opt/ -name maps.xdc` doesn't give any output.

r10s commented 2 months ago

just another data point: on mac/sonoma with arm-build (thanks for that, btw!), the map shows up

Raiden-GH commented 2 months ago

I have the same problem. When I click on the map icon in the bar or on "Open global map" nothing happens. When I click on the gallery icon it is always highlighted along with the map icon.

DC Karten

I found the following suspicious entries in the log:

2024-05-25T09:12:37.241Z renderer ERROR "\nfile:///Applications/DeltaChat.app/Contents/Resources/app.asar/src/renderer/App.tsx:109:10" "Unhandled Rejection:" {"isTrusted":true} {"stack":"Error: Error invoking remote method 'open-maps-webxdc': [object Object]\n at IpcRenderer.invoke (node:electron/js2c/sandbox_bundle:2:49458)","message":"Error invoking remote method 'open-maps-webxdc': [object Object]"} 2024-05-25T09:12:42.429Z renderer ERROR "\nfile:///Applications/DeltaChat.app/Contents/Resources/app.asar/src/renderer/App.tsx:109:10" "Unhandled Rejection:" {"isTrusted":true} {"stack":"Error: Error invoking remote method 'open-maps-webxdc': [object Object]\n at IpcRenderer.invoke (node:electron/js2c/sandbox_bundle:2:49458)","message":"Error invoking remote method 'open-maps-webxdc': [object Object]"} 2024-05-25T09:12:44.145Z renderer ERROR "\nfile:///Applications/DeltaChat.app/Contents/Resources/app.asar/src/renderer/App.tsx:109:10" "Unhandled Rejection:" {"isTrusted":true} {"stack":"Error: Error invoking remote method 'open-maps-webxdc': [object Object]\n at IpcRenderer.invoke (node:electron/js2c/sandbox_bundle:2:49458)","message":"Error invoking remote method 'open-maps-webxdc': [object Object]"}

missytake commented 2 months ago

When I click on the gallery icon it is always highlighted along with the map icon.

DC Karten

Same for me.

Simon-Laux commented 2 months ago

probably we need to instruct electron-builder to also put it into the asap.unpacked folder and then additionally adjust the code so it finds it when it is a release, similar to what I did for the rpc server in

https://github.com/deltachat/deltachat-desktop/blob/513bf80d7c6fa35459301da7b4ecf31edb4976c9/src/main/deltachat/controller.ts#L88-L91

Probably the issue is that electron can deal with those paths, but deltachat core does not understand what the asar archive is so it does not look inside of it.

Raiden-GH commented 2 months ago

I was now able to start DC via terminal. This messages are displayed there:

(node:2322) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time (Use DeltaChat --trace-warnings ... to show where the warning was created)

Error occurred in handler for 'open-maps-webxdc': { code: -1, message: 'failed to open file /Applications/DeltaChat.app/Contents/Resources/app.asar/html-dist/xdcs/maps.xdc\n' + '\n' + 'Caused by:\n' + ' Not a directory (os error 20)'

r10s commented 2 months ago

just another data point: on mac/sonoma with arm-build (thanks for that, btw!), the map shows up

i meanwhile have the same bug as well, not sure what has changed. at least, the bug is consistent now :)