search

deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
887 stars 166 forks source link

wrong aspect ratio for images shown in quotes #3931

Closed r10s closed 1 day ago

r10s commented 2 weeks ago

when quoting a message with an image, the quote gets enriched with the original image, which is great!

however, the quoted image is always force to be a square, without respecting the aspect ratio:

 

instead, either:

  1. display the whole image - however, the height should still not be larger than the quote. the image can be wider, however. displaying the whole image is also what desktop does otherwise, maybe one can reuse some code

  2. crop the image. this is done on mobile, as anyways already done for the normal image display (due to smaller screen and for $reasons). in case of desktop, however, i would show the image as its original, so go for 1.

all in all, this is a minor issue with low priority

Simon-Laux commented 2 weeks ago

probably could be solved by only setting height

r10s commented 2 weeks ago

yes, that would probably be totally fine