deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
943 stars 169 forks source link

notifications are sometimes not removed from notification center [needs step to reproduce] #3937

Open r10s opened 5 months ago

r10s commented 5 months ago

notifications show up in the notification center of mac, however, they are not removed when the corresponding chat is opened and the belonging messages are no longer "fresh".

eg. on android/ios, we dismiss all notifications belonging to a chat once the chat is opened, i assume sth. like that would be nice for desktop as well.

eg. the following image shows some profiles where none of them have a new message - but the notification center (rights) shows lots of messages, some of them days old:

Screenshot 2024-06-13 at 00 19 55

there was a similar issue at https://github.com/deltachat/deltachat-desktop/issues/2199, tbh, not sure when it stopped working again

Simon-Laux commented 5 months ago

eg. on android/ios, we dismiss all notifications belonging to a chat once the chat is opened, i assume sth. like that would be nice for desktop as well.

this is what it does for me, just tested it again.

I can not reproduce this, could those notifications be remaining from a previous session (like be from that bug: #2438, I'm not sure if we can solve that bug maybe we should just remove all notifications if you close deltachat?)

nicodh commented 5 months ago

Can't reproduce this in Catalina too. Works as expected...

r10s commented 5 months ago

i had similar many messages as in the image above just now.

clearing all these messages (i think, i tried that before, but well, not 100% sure), i can confirm, on explicit tries notificaitions are removed as expected.

also, quitting the app seem to remove all notification.

so, let's close this issue, maybe it was the case that in older versions notifications were not removed on exit and then got orphaned.

if i again see lots of stale notifications, i know that i removed them all by re-reading this message :)

r10s commented 5 months ago

ftr, having stale notifications again, however, i cannot say how to reproduce the issue yet.

i suspect it is somehow related to multiple devices

r10s commented 5 months ago

i have the issue again, btw.

i suspect, it is related to multi-device somehow, but i did not find a way to reproduce it somehow. it is just that after some time not watching, the notification center is flooded as shown in the image above.

Simon-Laux commented 5 months ago

So you haven't restarted it in between?

r10s commented 5 months ago

So you haven't restarted it in between?

exiting the app does remove all notifications for me, that works.

so, yes, i probably have not restarted for some time.

in general, the app is running for hours, sometimes days, including suspend times where i use a second device. i suspect that is where things somehow go wrong. but as said, i cannot really say more than that it happens :)

Simon-Laux commented 4 months ago

Have you started and stopped from command line or killed the app otherwise? then it might not have a chance to clear old notifications?

r10s commented 4 months ago

no, not that i was aware of

WofWca commented 4 months ago

See if reproduction steps in https://github.com/deltachat/deltachat-desktop/issues/3982 work for you

Simon-Laux commented 3 months ago
Bildschirmfoto 2024-08-01 um 00 05 55

I believe there is no logic to clear those generic / summarised notifications. Those piled up for me in my notification center. we should clear all of those summary messages when delta chat is focused. but this might deserve a dedicated issue?