Changing language does not immediately update the strings

deltachat / deltachat-desktop

Email-based instant messaging for Desktop.

GNU General Public License v3.0

909 stars 167 forks source link

Changing language does not immediately update the strings #3974

Open farooqkz opened 2 months ago

farooqkz commented 2 months ago

Operating System (Linux/Mac/Windows/iOS/Android): Linux (deb)
Delta Chat Version: 1.46.1
Expected behavior: Upon changing the language, all strings must be replaced with the strings of the new language
Actual behavior: It takes some time, perhaps needs re-render
Steps to reproduce the problem: Just change the language and see some strings are still in the old language
Screenshots:
Logs:

Softly depends on https://github.com/deltachat/deltachat-desktop/pull/3889

farooqkz commented 2 months ago

Alright the problem seems to be with window.static_translate...

farooqkz commented 2 months ago

Since from what I can see, it is mostly for timestamps, or at least partially, let's wait for luxon to replace moment and see how it'll go.

Simon-Laux commented 2 months ago

try to find the exact places where this happens, you can add a updateTimestamps() call to reloadLocaleData in App.tsx and test if that would already solve the issue. or we need to use useTranslationFunction in more places.