deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
947 stars 169 forks source link

tab-navigation incomplete/erroneous #4127

Open r10s opened 2 months ago

r10s commented 2 months ago

4005 adds "tab navigation" to improve accessibility, so to help users who cannot or do not want to use a mouse.

the idea of the "tab navigation" is that it can replace a mouse completely.

however, there are some open ends with the navigation:

sorry for nitpicking, but to make "tab navigation" useful, it should be coherent.

note, that "other shortcuts" are are more for power-users and are not a replacement for "tab navigation" issues: "tab navigation" should be useful without learning additional shortcuts, as said, being used as a mouse replacement

for further reading see eg. https://www.nngroup.com/articles/keyboard-accessibility/

WofWca commented 2 months ago

Could you clarify these?

in the message list, random "emoji picker" icons are selected - the ones the mouse is hovered

there is not tab-stop for the "profile"

What profile?

r10s commented 2 months ago

Could you clarify these?

in the message list, random "emoji picker" icons are selected - the ones the mouse is hovered

see the following image:

the mouse is randomly over the message "gg" - and then the buttons beside the message can be reached via tab. but this does not make sense, the whole idea of the tab-navigation is that the mouse is not needed. and you cannot reach the context menu of another message without mouse.

there is not tab-stop for the "profile"

What profile?

the one that opens when tapping here:

Simon-Laux commented 1 month ago

Settings: selections dialog elements and switch elements are not focusable:

https://github.com/user-attachments/assets/2f74f761-c496-4b53-8d5d-476ec96e880a

maxphilippov commented 1 month ago

Settings: selections dialog elements and switch elements are not focusable: Bildschirmaufnahme.2024-10-07.um.18.53.07.mp4

Selects are selectable in #4006 and probably in main, Radio groups are probably what you mean, switches aren't selectable

That's a pretty easy fix, I'll add that to #4006, so we don't drown in merges