deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
938 stars 166 forks source link

unexpected "Escape" key behaviours #4128

Open r10s opened 1 month ago

r10s commented 1 month ago

the "Escape" key is working only in some situations, and not always predictable.

some inconsistencies:

EDIT: some more:

WofWca commented 1 month ago

FYI some of these might get resolved in the Blueprint removal MR.

maxphilippov commented 4 weeks ago

Turns out none of these are solved by #4006 cause a lot of the dialogs are actually implemented as a switch between different states rather than stacking, but this looks like a pretty straightforward refactor, I'll probably do that after Blueprint removal PR is merged since there's a lot of Dialog-related code

UPD: I realized that ContextMenu-related things are probably actually solved by the PR, after I solve a little bug reported by Simon in #4006, cause ContextMenu is now a part of the dialog stack.

maxphilippov commented 2 weeks ago
  • enlarge image -> context menu -> esc closes image and keeps context menu

Just as an update for someone who's gonna work on this. On current main after Blueprint removal:

  • enlarge image -> context menu -> close context menu -> esc does not work

Escape works now

These are fixed in #4205