Open r10s opened 2 months ago
FYI some of these might get resolved in the Blueprint removal MR.
Turns out none of these are solved by #4006 cause a lot of the dialogs are actually implemented as a switch between different states rather than stacking, but this looks like a pretty straightforward refactor, I'll probably do that after Blueprint removal PR is merged since there's a lot of Dialog-related code
UPD: I realized that ContextMenu-related things are probably actually solved by the PR, after I solve a little bug reported by Simon in #4006, cause ContextMenu is now a part of the dialog stack.
- enlarge image -> context menu -> esc closes image and keeps context menu
Just as an update for someone who's gonna work on this. On current main
after Blueprint removal:
- enlarge image -> context menu -> close context menu -> esc does not work
Escape works now
- settings -> esc works
- settings -> chats and media -> esc does not work (there is a dedicated issue for that at Settings should be closable in sub-pages with escape key #3868)
- settings -> chats and media -> back -> esc does not work
These are fixed in #4205
the "Escape" key is working only in some situations, and not always predictable.
some inconsistencies:
EDIT: some more: