deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
944 stars 169 forks source link

add "learn more"-button beside manage-keys section, link to #importkey #4155

Open ell1e opened 1 month ago

ell1e commented 1 month ago

Sorry if it's just me being silly, but I think from the UI it's not quite clear what exact format the key import dialog wants. It says "PGP Key" in the filter below, but it doesn't say if it wants one of the plain text formats or which, and my actual *.pgp key files aren't shown, and there is no reason given and seemingly no way to make the dialog actually show them. If I am meant to convert them to a specific format that's fine, but I would need to know which, since it's seemingly not telling me what file extension it's even filtering for. Unless it's written somewhere obvious and I just missed it, in that case my apologies.

ell1e commented 1 month ago

After some more investigation, there seem to be potentially multiple issues here:

r10s commented 1 month ago

there are quite some information available at https://delta.chat/en/help#importkey , we could improve that (if needed) and link there, as we do already in other cases (via a "Learn More" button or so)

note, to keep thing actionable, we'll focus in this issue on helping the user to understand the current state.

the removal of the passphrase is out of scope of this issue, this is better done by external tools as otherwise the user would also expect to enter a passphrase any time delta chat is opened, which is not how delta chat works currently. however, there is a feature proposal in the forum

r10s commented 1 month ago

k, after a quick internal discussion, we'll add a "Learn More" button beside "Manage Keys" that will link to #importkey in the internal offline help (this is same as https://delta.chat/en/help#importkey).

this will make the existing information easier accessible, directly where questions may occur. the "manage keys" functions are only for advanced power users anyways and a "help page" explaining things seems appropriate because of the complexity of classic GPG & Co. if needed, we can improve the help, as we already did several times in the past.

https://github.com/deltachat/deltachat-android/pull/3328 and https://github.com/deltachat/deltachat-ios/pull/2309 show how this could look like, including screenshots.

in case of desktop, we do not have a dedicated "Manage Keys" dialog. i would be fine with just adding the "Learn More" button at the end of the "Encryption" section ...

Screenshot 2024-10-02 at 20 01 10

... though combining them to a "Manage keys" dialog as on android/ios would be even nicer :)