deltachat / deltachat-desktop

Email-based instant messaging for Desktop.
GNU General Public License v3.0
948 stars 169 forks source link

[UX] Entering some sort of join link or room id into the search after pressing the "+" button doesn't offer to let me join #4158

Open ell1e opened 1 month ago

ell1e commented 1 month ago

I found a chat room that I was asked to join, and it's specified via some OPENPGP4FPR:... id. Alternatively, I was given a link starting with https://i.delta.chat/#....

Neither will open in the regular desktop chat client if I enter them in the two obvious locations:

Screenshot_20241001_184143

Screenshot_20241001_184027

This makes it unnecessarily confusing to figure out how to even join a room without a mobile phone. I suggest that this is changed.

Simon-Laux commented 1 month ago

great idea!

For now you can also send the link in self send/saved messages and click on it. Or "scan" it with the settings wheel in the qr code scanner dialog.

CC @r10s (what do you think?)

WofWca commented 1 month ago

I thought I added this to the chat list search in https://github.com/deltachat/deltachat-desktop/pull/4041, which was released in 1.46.2...

There was another small improvement #4151, which is not released yet. And @nicodh suggested to add this to the contact search as well: https://github.com/deltachat/deltachat-desktop/pull/4151#pullrequestreview-2336857429

r10s commented 1 month ago

I thought I added this to the chat list search in https://github.com/deltachat/deltachat-desktop/pull/4041, which was released in 1.46.2...

yeah, i can confirm, that it works in general.

but it seems too implicit, to show the generic "New Contact" button that is shown at other places as well, where the user has to enter an email address.

as a quick improvement, the button could read "Chat with CHATNAME".

WofWca commented 1 month ago

An even better improvement would be to read the clipboard, detect that it's an invite link, and suggest appropriate action.

ell1e commented 1 month ago

It may seem a little weird if an app is constantly watching to clipboard changes even when no button is pressed, at least I personally don't know any app that does it. Maybe that's just me though?

it seems too implicit, to to show the generic "New Contact" button that is shown at other places as well,

You're saying after pasting I would have simply needed to click that? Interesting, that didn't occur to me since it didn't reflect a clear reaction to recognizing a room. I would suggest it should change to "Join group chat [group chat name]" or something, when a group chat reference was pasted.

r10s commented 1 month ago

we should stay with manual paste.

always watching the clipboard is considered at least strange. some os even show a hint every time the clipboard is read - even if that is not yet the case now for desktop, it might be cause for trouble in the future.

WofWca commented 1 month ago

the button could read "Chat with CHATNAME".

We have "Chat with %1?", with a question mark.

https://github.com/deltachat/deltachat-desktop/blob/0049dc4bfb0f13a8848e613e4d96026bf5381354/_locales/en.xml#L356

Shall we use this string, or make a new one?

r10s commented 1 month ago

better a new one without the question mark.

question marks on button-like controls are unusual.

WofWca commented 1 month ago

Actually you know what. I think we can simply display the item as a contact. I.e. move the name to the header and empty the subheader (or replace it with the email address). No need for call-to-action texts. Since an invite link is practically a link to a contact. What do you think?