Add UI to reset encryption

deltachat / deltachat-desktop

Email-based instant messaging for Desktop.

GNU General Public License v3.0

951 stars 170 forks source link

Add UI to reset encryption #4312

Open link2xt opened 3 weeks ago

link2xt commented 3 weeks ago

There is a core PR to adding JSON-RPC API to reset encryption: https://github.com/deltachat/deltachat-core-rust/pull/6170

It is needed to close https://github.com/deltachat/deltachat-core-rust/issues/4465

"Reset Encryption" could be in the contact profile menu after "Encryption Info" or inside the Encryption Info dialog: reset_encryption

Should probably be red as it is not a reversible action.

For chatmail profiles can be completely hidden as resetting encryption there in most cases makes it impossible to send messages. Could also be hidden if developer options are not enabled.

r10s commented 3 weeks ago

not sure if this meant as a developer option or not. in both cases, the following would be fine:

let's put it as a button inside "encryption info", it is pretty advanced and should not be present in the primary ui.
should be a normal, unexcited button below the fingerprints. not sure if it needs to be "red", it is reversible when a new encrypted message comes in, this happens also automatically all the time without the user being asked
+1 for hiding for chatmail

iequidoo commented 3 weeks ago

Technically it's easy to make it revertible, but then an extra translation is needed at least. I think if it's not a dev option, it should be red, otherwise i'm almost sure there will be complains why it's not possible to set encription back. But maybe just make it a dev option, do they require translation?

Simon-Laux commented 3 weeks ago

"reset encryption" is not a good name, took me a while to figure out what is meant by that. If this is user visible it should have a clearer name and maybe also a link to an FAQ entry next to it that explains what it means