"Show Full Message…" window has "Show remote images" option even when there are no remote images

[dkg]

• Operating System (Linux/Mac/Windows/iOS/Android): Debian GNU/Linux trixie (testing)
• Delta Chat Version: 1.48.0
• Expected behavior: only present "Show Remote Images" checkbox when a message actually has remote images
• Actual behavior: "Show Remote Images" checkbox appears in every large message.
• Steps to reproduce the problem: Send a long message with no remote images or other resources to an account with deltachat-desktop. click "Show Full Message …". look in the upper right corner of the new window.

Having the "Show remote images…" option present even when there are no remote images simply encourages people to get used to checking that box just to see whether the message they get will change. this is unhealthy conditioning.

[r10s]

technically, iirc, it is not that easy to know if a message uses external things or not. there are lots of ways to specify images and thelike in html. doable sure, but at least that time, we did not want to start maintaining these things, focusing and fixing other things instead.

this is unhealthy conditioning.

agree.

what we're doing on android/iOS is to not show the button in the primary UI, so it is not that much in your face, shouting "tap me!! try me!!!!". only if you think "hmm, sth. is wrong", you'll find the three-dot-menu and tap the corresponding option.

even if we would have an api that precisely tells us if there is an image or not, the android/iOS approach might be nicer (also clutters UI less)