deltachat / deltachat-ios

Email-based instant messaging for iOS.
Other
327 stars 52 forks source link

add 'select all' and 'mute' to chatlist #2347

Closed r10s closed 1 month ago

r10s commented 1 month ago

this PR adds some features recently added to Android:

moreover, the PR cleans up the old "mute dialogs", using the new approach.

of course, among other things, there are also ideas to a mute to the swipe-action as well, but this is another thing :)

Amzd commented 1 month ago

Maybe this is a good PR to add two finger swipe selection? I was missing it already and it's basically just a more native way to select many items that many other apps already have. https://developer.apple.com/documentation/uikit/uitableviewdelegate/selecting_multiple_items_with_a_two-finger_pan_gesture

Amzd commented 1 month ago

If you think this is the correct place for it you can cherry pick https://github.com/deltachat/deltachat-ios/commit/fbe791a68bcc320619791de95ffbf108fa821fd9

otherwise I will open a separate PR

r10s commented 1 month ago

otherwise I will open a separate PR

let's keep things on point, this is better for review and following.

in general, we prefer small on-point-prs that do a "single thing"

so, i'd merge this PR as is, and we can do a separate PR for the two-finger-swipe -- which, btw, i was not aware of at all - i was thinking all the time, Signal does not even have a multi-select-mode! from known messengers, it seems to be supported by Signal and iMessage only, so, i would not expect users to know about that - in contrast to long tap. but we can just do both, i think, this is also the idea

EDIT: also Telegram supports two-swinger-swipe, but only badly, the fingers need to be closer together, so i thought first it is unsupported (maybe they do it on their own, as so many ui things, and emilated the system only poorly here)

Amzd commented 1 month ago

The two finger swipe is supported by many of the native apps (Mail, Notes, Reminders, Photos). GitHub app supports it (when selecting lines to comment on in review). My recipe app supports it.

So it's not that rare and would be nice to have, and yea probably only used by people that know these kinds of hidden gestures but very useful.

I will open a separate PR

r10s commented 1 month ago

let'smerge this one in then, to avoid conflicts.