Closed r10s closed 2 weeks ago
this PR fixes the duplicated proxy entries mentioned at https://github.com/deltachat/deltachat-ios/pull/2388#pullrequestreview-2432766803 - we first thought it is a core-bug, but eventually was not.
this was a hard to find bug ... i hope i could explain it correctly :)
core normalizes proxy-url when calling set_config_from_qr(URL_ORG).
set_config_from_qr(URL_ORG)
by calling set_config(URL_ORG) instead of URL_NORM=get_config() after adding, we discarded the normalisation.
set_config(URL_ORG)
URL_NORM=get_config()
selecting later by set_config_from_qr(URL_ORG) finally results in URL_ORG as well as URL_NORM being added to the list.
URL_ORG
URL_NORM
one could argue, that normalisation should also take place at set_config(), however, this is not the case.
set_config()
it also seems more resilient to refresh the list on adding, so that really the state and the URLs used on core are shown.
this PR fixes the duplicated proxy entries mentioned at https://github.com/deltachat/deltachat-ios/pull/2388#pullrequestreview-2432766803 - we first thought it is a core-bug, but eventually was not.
this was a hard to find bug ... i hope i could explain it correctly :)
core normalizes proxy-url when calling
set_config_from_qr(URL_ORG).by calling
set_config(URL_ORG)instead ofURL_NORM=get_config()after adding, we discarded the normalisation.selecting later by
set_config_from_qr(URL_ORG)finally results inURL_ORGas well asURL_NORMbeing added to the list.one could argue, that normalisation should also take place at
set_config(), however, this is not the case.it also seems more resilient to refresh the list on adding, so that really the state and the URLs used on core are shown.