Closed homdx closed 5 years ago
It's hard for me to follow your actual steps, did you get node-gyp-build scripts/rebuild-core.js
to work? The error message seems like cmd.exe somehow thinks that scripts is a command, i'm not a windows pro, maybe you need soemthing like node-gyp-build ./scripts/rebuild-core.js
? Maybe it's only a problem of how to pass path arguments on windows?
Currently I don't have a windows machine around, but will give it a try the next days. Thanks a lot for your efforts!
EDIT: Also found some install instructions for windows, maybe we need to do some more windows specific pre installation things? https://github.com/nodejs/node-gyp#on-windows
node-gyp-build scripts/rebuild-core.js
@vweevers You wouldn't know why this would be problematic on windows by any chance?
It's the following line in node-gyp-build
that is being executed (@Jikstra you might be onto something with the path there)
https://github.com/prebuild/node-gyp-build/blob/master/bin.js#L60
It's not the path, it's that you're executing scripts/rebuild-core.js
rather than node scripts/rebuild-core.js
.
We need something similar to https://github.com/prebuild/prebuild/blob/3471b49372060ab60a72cee974aadfe335cb5386/util.js#L40-L46 in node-gyp-build
.
Oh right, when I think of it I've seen this before. In sodium-native
they do https://github.com/sodium-friends/sodium-native/blob/master/package.json#L23
Now you can reproduce build under windows: https://github.com/deltachat/deltachat-desktop/issues/606#issuecomment-465064978
Need help, node-gyp-build under windows and pass node tests:
**Questions:
2. For test binary whats are need?
npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! deltachat-node@0.39.0 test:
echo 1 && standard && echo 2 && nyc.cmd no de test/index.js
npm ERR! Exit status 1}],
c:\Project\deltachat-node\deltachat-core>dir builddir\libs\libetpan\ 10.02.2019 13:35
Error: No native build was found for runtime=electron abi=69 platform=win32glibc arch=x64 at Function.load.path (C:\Project\deltachat-node\node_modules\node-gyp-build \index.js:69:9) at load (C:\Project\deltachat-node\node_modules\node-gyp-build\index.js:20:2 0) at Object. (C:\Project\deltachat-node\binding.js:1:198)
at Object. (C:\Project\deltachat-node\binding.js:3:3)
at Module._compile (internal/modules/cjs/loader.js:693:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
at Module.load (internal/modules/cjs/loader.js:602:32)
at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
at Function.Module._load (internal/modules/cjs/loader.js:533:3)
at Module.require (internal/modules/cjs/loader.js:640:17)