deltachat / deltachat-node

Email-based instant messaging for Node.js.
GNU General Public License v3.0
45 stars 11 forks source link

Update deltachat-core-rust to new (unreleased) core #497

Closed Jikstra closed 3 years ago

Jikstra commented 3 years ago

ToDo

Functions: rm dc_is_io_running ✅ add dc_get_chat_encrinfo ✅ add dc_get_msg_html✅ add dc_msg_get_real_chat_id✅ add dc_msg_get_override_sender_name✅ add dc_msg_has_html✅ add dc_decide_on_contact_request✅ add dc_msg_set_html✅ add dc_msg_set_override_sender_name✅ rm dc_contact_get_first_name ✅ add dc_contact_get_auth_name✅ add dc_contact_get_status✅ add dc_msg_get_subject✅

Simon-Laux commented 3 years ago

why Don't add constants where value is not a number? what constants are included that are not numbers? Edit: just a curiosity question, its probably good to have that check there anyway.

r10s commented 3 years ago

removal of ImapFolder config option?

what is that option about?

Simon-Laux commented 3 years ago

what is that option about?

that's the question? its the watch folder setting afaik and the new core watches all folders if i understood it correctly, so my question is whether we need to remove the watch folder setting from desktop when using the new core.

r10s commented 3 years ago

its the watch folder setting afaik and the new core watches all folders if i understood it correctly, so my question is whether we need to remove the watch folder setting from desktop when using the new core.

i see ;) the options should stay as is for now, might be they get superfluous at some point, but we are not there yet.