search

deltachat / deltachat-node

Email-based instant messaging for Node.js.
GNU General Public License v3.0
45 stars 11 forks source link

Add -Bsymbolic linker flag to hide sqlite symbols #539

Closed link2xt closed 2 years ago

link2xt commented 2 years ago

This prevents electron, which links against SQLite, from overriding SQLCipher used in libdeltachat during dynamic linking.

Fixes #538

Simon-Laux commented 2 years ago

the export works now, I got an electron error which is probably unrealated, but I'll still post it here for reference:

[48279:0302/214110.712573:ERROR:vaapi_wrapper.cc(1123)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[48279:0302/214110.712733:ERROR:vaapi_wrapper.cc(1070)] FillProfileInfo_Locked failed for va_profile VAProfileH264Main and entrypoint VAEntrypointVLD
[48279:0302/214110.712776:ERROR:vaapi_wrapper.cc(1123)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[48279:0302/214110.712811:ERROR:vaapi_wrapper.cc(1070)] FillProfileInfo_Locked failed for va_profile VAProfileH264High and entrypoint VAEntrypointVLD

to be clear export worked on linux with this pr in both node and electron

dotlambda commented 2 years ago

Signal added another flag, I don't know if that's something we also want: https://github.com/signalapp/better-sqlite3/pull/3

dotlambda commented 2 years ago

There is a related issue in the Matrix ecosystem: https://github.com/matrix-org/seshat/issues/102