search

deltachat / deltachat-node

Email-based instant messaging for Node.js.
GNU General Public License v3.0
45 stars 11 forks source link

fix windows make package and prepare 1.75.3 #543

Closed Simon-Laux closed 2 years ago

Simon-Laux commented 2 years ago

upgrade node-gyp: maybe this fixes the windows problem, though we should look at its changelog to make sure we're not affected by breaking changes

Update: it fixes the issue and I did not see any breaking changes in node-gyp's changelog

Simon-Laux commented 2 years ago

works on windows now, though the linux integration test crashes: 

ignoring careless call to dc_accounts_event_emitter_unref()
    ✓ new message and Message methods
    ✓ Contact methods
    ✓ create contacts from address book
    ✓ delete contacts
free(): invalid pointer
Aborted (core dumped)
Error: Process completed with exit code 134.

locally on MacOS it works

Simon-Laux commented 2 years ago

ok looks like it works now in the ci too, I'll take that