Closed hpk42 closed 4 years ago
+1
On March 30, 2019 12:10:47 PM GMT-04:00, holger krekel notifications@github.com wrote:
"login manually" would be better than "cancel" i think. One never quite knows what "cancel" does -- it is easily interpreted as one of those "click-through" screens everybody grew accustomed with.
hm, not sure. i think, either both buttons should be explicit or none. sth. as an explicit named cancel button vs. an implicitly (refering to the text) ok-button looks a bit strange to me.
so maybe either "cancel"<>"continue" or "login manually"<>"simplified setup" buttons.
otoh - if the user does not read and clicks-through, this is not the worse in this case. if oauth2 fails, he will come back anyway ...
playing around with the change (i am currently playing around with a lot of log in stuff), i think this change is not really an improvement, i reasoned about it at https://github.com/deltachat/deltachat-android/pull/1231/commits/3d62b128b91207c82e994205674fd8a945489c82 and reverted the changed there.
feel free to reopen this issue if needed.
"login manually" would be better than "cancel" i think. One never quite knows what "cancel" does -- it is easily interpreted as one of those "click-through" screens everybody grew accustomed with.