search

deltachat / interface

General and shared components and discussions relating to deltachat user interface
8 stars 3 forks source link

imprecise "Scan QR Code" wording #60

Open r10s opened 7 months ago

r10s commented 7 months ago

since 1.42, we have some dialogs that pop up when a contact requires to be "green checkmarked" but is not, eg.

Screenshot 2024-02-05 at 17 45 43 Screenshot 2024-02-05 at 18 06 53 Screenshot 2024-02-05 at 17 56 35

on android/ios, the "Scan QR code" button opens the "QR Code" activity that allows showing and scanning QR codes (last tab is remembered). desktop forces scanning, however, still allows showing QR code - which makes a lot of sense, the functionality seems fine.

however, the wording may be regarded as being bit imprecise when the dialog button reads "Scan QR code" and the dialog is opened at "show" and "scan" requires another tap. otoh, while i totally get the point why it may be confusing, "Scan QR code" can also be read as the process of interacting with QR codes, no matter who scans or shows.

question is, if there is a better wording for the button that covers both cases better and is equally actionable, short (button text!) and easy to understand.

there is also the option to open the "QR Code" activity really always in scan-mode, but it is not sure if this is a more helpful default in practise - and it would also block improving wrt showing group-invites directly (currently we do not), we may land easier in issues when the camera is not functional, and the current hint is also pretty generic (and less helpful than "Scan this to chat with ...")

Simon-Laux commented 7 months ago

(last tab is remembered)

why? I think remembering makes little sense, If you go there manually I would just default to showing your own qr code and when you come there from a dialog that talks about scanning it should open in the scan view. - Activities support arguments, I see no reason to not open in the tab where it makes most sense.

We could make it clearer that there are tabs and that you can scan by adding a button beneath the own qr code that says "Scan".

group-invites more hidden

group invites should have no option to scan. I would just hide the tab/option it if reusing the same dialog or show it in a dedicated view like on desktop.

PS: If there should be problems with the camera then we should try to fix those, is there an issue for the android one? Do we already use the async camera api on iOS?

r10s commented 7 months ago

there are older discussions about both points eg. at https://github.com/deltachat/deltachat-android/pull/1190

however, before thinking about adapting functionality, which is fine as is for now, let's see if we can just improve the button text, i did some suggestions at https://github.com/deltachat/deltachat-ios/pull/2062#issuecomment-1927049501

adbenitez commented 7 months ago

group invites should have no option to scan. I would just hide the tab/option it if reusing the same dialog or show it in a dedicated view like on desktop.

This is how it works in android, group invite screen shows only QR, no scan tab, /me confused

Simon-Laux commented 7 months ago

iOS does not remember on what qr code mode (show/scan) you were across sessions, another reason to not value this remember "feature" too much.

adzialocha commented 7 months ago

The wording seems fine with me, I'm not sure if this is the crucial point (the signalling word is "QR Code"). Something like "Connect via QR Code" is maybe more neutral and also good.

+1 for making the "Scan" tab pre-selected when coming from this dialog