search

deltachat / interface

General and shared components and discussions relating to deltachat user interface
8 stars 3 forks source link

mention that "Invite Links" use a OPENPGP4FPR variant #61

Closed r10s closed 7 months ago

r10s commented 7 months ago

closes https://github.com/deltachat/invite/issues/19

Simon-Laux commented 7 months ago

do you really think that is enough and matches the level of detail that the file already sets? I'm very disappointed. I'll make a followup pr, I planned to do this anyway to tell you the truth.

r10s commented 7 months ago

do you really think that is enough and matches the level of detail that the file already sets? I'm very disappointed.

although striked through: i assume, you have not noticed that the linked repo contains a new README explaining invite-links and differences to OPENPGP4FPR, without much duplication. also note, that there was just nothing before :)

I'll make a followup pr, I planned to do this anyway to tell you the truth.

thanks! sure, things can always be improved on iterations. which apps have registered now https-scheme with host=i.delta.chat is indeed missing, if that is what the issues wanted to refer to. and yes, PR are much more appreciated than issues with advices and/or getting stale, esp. on side-projects or internal documentations without real maintainers.

Simon-Laux commented 7 months ago

i assume, you have not noticed that the linked repo contains a new README explaining invite-links and differences to OPENPGP4FPR

Indeed I have missed that, I also wasn't expecting it there. I'll copy the wording where possible so the review will be easier.

Simon-Laux commented 7 months ago

The readme of https://github.com/deltachat/invite/ is actually really nice, but it is more targeted at users (tells how to create a link) and does not describe how the format exactly works (escaping of the # char after the fingerprint) and does not mention platform support as you already mentioned in your comment above.