deltachat / invite

Invite links for deltachat
https://i.delta.chat
GNU Affero General Public License v3.0
10 stars 1 forks source link

Consider moving invite conversion logic from UI code into core as well #28

Open Simon-Laux opened 10 months ago

Simon-Laux commented 10 months ago

desktop, iOS and android duplicate the same logic, why not return it from core instead of the current raw OPENPGP4FPR link, or should that still be used somewhere?

https://github.com/deltachat/deltachat-ios/blob/9c3c7a754bbbc92503db380efe610d0aff781716/deltachat-ios/Helper/Utils.swift#L45

https://github.com/deltachat/deltachat-desktop/blob/3b8f0275ff8619083ae304ec86347fbc0047db88/src/renderer/utils/invite.ts

https://github.com/deltachat/deltachat-android/blob/953a8882397e9e65ee000bad325853052f91f3b2/src/org/thoughtcrime/securesms/util/Util.java#L81

r10s commented 4 months ago

related: we're considering to let core return always i.delta.chat-links. only the invite page would generate the OPENPGP4FRP:-links then. cmp https://github.com/deltachat/deltachat-core-rust/issues/5467