search

deltachat / invite

Invite links for deltachat
https://i.delta.chat
GNU Affero General Public License v3.0
10 stars 1 forks source link

add russian translation #40

Closed missytake closed 3 months ago

missytake commented 3 months ago

Can a native speaker take a second look at this?

Also I'm not sure if the localization scheme works at all right now, switching chromium to french already doesn't work for me on main branch, I still see the english text. But tests pass, and updating i18next.js doesn't change anything, so maybe it's fine?

related: #39

missytake commented 3 months ago

@iequidoo Now that it's deployed, can you confirm whether the translation is shown for you?

iequidoo commented 3 months ago

i.delta.chat still says "Say hello to iequidoo" while https://delta.chat brings me to https://delta.chat/ru/. FF 115.10.0esr

rosano commented 3 months ago

I'm not sure if it was redirecting before, but I thought it would at least check for preferred language. I can access French https://i.delta.chat/?lang=fr and Russian https://i.delta.chat/?lang=ru with a query parameter.

iequidoo commented 3 months ago

Yes, i tried to change my preferred language in FF, but that didn't help for http://i.delta.chat. But if i add ?lang=ru, it works and looks good.

EDIT: Now it works if i change my preferred language, but it looks that FF caches smth so i need to open a "New private window". Not that important i think.

link2xt commented 3 months ago

Language gets stored into "local storage" by this i18next library.