search

deltachat / mailadm

mail account administration tool for temporary and other account creation/modification
https://mailadm.readthedocs.io/
Mozilla Public License 2.0
14 stars 1 forks source link

wrote test for gen_qr - failing with qrcode==7.4.0 #106

Closed missytake closed 1 year ago

missytake commented 1 year ago

closes #105

Version 7.4.0 of the https://pypi.org/project/qrcode/#history library has introduced a bug, resulting in all QR codes mailadm generates being unreadable. We discovered this during a live test with users, very unfortunate.

I pushed a hotfix to master this morning, pinning the qrcode version to 7.3.1 - this PR reverts the hotfix and introduces a test for our gen_qr() function, which was untested so far.

The test works with qrcode==7.3.1, but fails with qrcode==7.4.0. We can merge this PR as soon as the CI turns green.

missytake commented 1 year ago

Now that qrcode 7.4.1 is released, the test passes! I also tried it out manually.