deltachat / mailadm

mail account administration tool for temporary and other account creation/modification
https://mailadm.readthedocs.io/
Mozilla Public License 2.0
14 stars 1 forks source link

Only expire unused accounts #111

Closed missytake closed 1 year ago

missytake commented 1 year ago

This PR introduces soft expiry according to https://github.com/deltachat/mailadm/issues/21#issuecomment-1453556526:

There is a test which specifies in the test parameters when we expect accounts to expire and when we expect them to not expire. This makes it easy to change the policy in the future. Any further suggestions on test cases?

This PR does not introduce a limit to soft expiry - if an account was supposed to live for at least a month, and someone is accessing it at least once a week, we still keep it around. But: both the method and the test are written in a way that we can easily change this behavior in the future.

missytake commented 1 year ago

At some point we should add some documentation on what options the tokens can have, but that's no release blocker I guess.

missytake commented 1 year ago

(CI is broken because dc.develcow.de is broken, but it runs successfully with testrun.org)