deltachat / mailadm

mail account administration tool for temporary and other account creation/modification
https://mailadm.readthedocs.io/
Mozilla Public License 2.0
14 stars 1 forks source link

chore: update core to 1.120.0 #126

Closed link2xt closed 11 months ago

link2xt commented 1 year ago

Currently the test tests/test_bot.py::TestSupportGroup::test_support_group_relaying fails.

There is a strange line in the log:

4.10 [events] INFO src/chat.rs:288: Created group/mailinglist 'pytest-supportuser-81152@ci.testrun.org support group' grpid=4qTKWbiVT7J as Chat#12, blocked=Yes.

This log comes from the admin account (there is such chat 12 in botadmin.db at the end of the test). Somehow the chat is created blocked (Blocked::Yes, not even Blocked::Request).

Also 1:1 chat with the bot is blocked in the bot admin database (also Yes, not just Request). Bot contact is fine, not blocked. I have looked into admbot.db, and the bot has 1:1 chat with pytest-admin-...@ci.testrun.org blocked (1 aka Yes, not 2 aka Request). 1:1 chats being blocked seems to be expected, this is needed to hide system messages about securejoin that go to 1:1 chat when joining a group: https://github.com/deltachat/deltachat-core-rust/blob/4d74f625d3962877a7462eec86f894d9c3bd68ea/src/securejoin/bob.rs#L33-L42

But the group chat getting blocked in the admin database is wrong.

I now suspect the change https://github.com/deltachat/deltachat-core-rust/pull/4316 which got into the core 1.113.0. This is why we are stuck at the core 1.112.7 and cannot upgrade further.

link2xt commented 1 year ago

I have created a core issue for this: https://github.com/deltachat/deltachat-core-rust/issues/4690

UPD: core 1.122.0 has this bug fixed, once it is pushed to PyPI we can update to it.

link2xt commented 11 months ago

Replaced with #128