search

deltachat / mailadm

mail account administration tool for temporary and other account creation/modification
https://mailadm.readthedocs.io/
Mozilla Public License 2.0
14 stars 1 forks source link

Add years, minutes, and seconds as expiration times #94

Closed missytake closed 1 year ago

missytake commented 1 year ago

closes #77

The main purpose of this PR is handling some cases in which users might add unexpected input - seconds will not have much use in production, as prune() is only executed every 10 minutes. But it's still interesting to keep around, as developers can trigger prune() earlier by restarting mailadm or running mailadm prune manually, so it's useful for testing purposes even if we can't guarantee that users are indeed created 10 seconds after their creation if their token is only giving them 10 seconds.

missytake commented 1 year ago

Hm, the test passes locally... I'll investigate.

missytake commented 1 year ago

Uff, seems to be a regression in core105 - it still passed with core101.

missytake commented 1 year ago

Ah, not a regression, but a fix :D the test had a workaround for https://github.com/deltachat/deltachat-core-rust/issues/3650, which is not necessary anymore and causes the test to fail now. Removing it fixes it. I opened a separate PR: https://github.com/deltachat/mailadm/pull/97