search

deltachat / message-parser

Parsing of Links, Email adresses, simple text formatting (markdown subset), user mentions, hashtags and more in DeltaChat messages.
https://deltachat.github.io/message-parser/
Other
12 stars 2 forks source link

fix: restrict elements that can appear inside of a label for a labled link #74

Closed Simon-Laux closed 5 months ago

Simon-Laux commented 5 months ago

closes #59

Simon-Laux commented 5 months ago

Can you think of some way to combine parse_element in markdown_elements.rs and parse_markdown_label_element in label_elements.rs?

yes there are ways, but all that I can think of would likely reduce performance (function returning a parser) or increase complexity (macros).

farooqkz commented 5 months ago

Can you think of some way to combine parse_element in markdown_elements.rs and parse_markdown_label_element in label_elements.rs?

yes there are ways, but all that I can think of would likely reduce performance (function returning a parser) or increase complexity (macros).

Function returning a parser could get inlined.