search

deltachat / notifiers

Notify devices
Apache License 2.0
6 stars 0 forks source link

Notification failure does not result in token removal #12

Closed link2xt closed 8 months ago

link2xt commented 8 months ago

Log contains a lot of error 400 codes like this:

Feb 18 23:12:01 page notifiers[155882]: {"level":50,"time":1708297921762,"msg":"failed to send notification: 8f...dd, ResponseError(Response { error: Some(ErrorBody { reason: DeviceTokenNotForTopic, timestamp: None }), apns_id: Some(\"...\"), code: 400 })"}

Also this:

Feb 18 23:11:17 page notifiers[155882]: {"level":50,"time":1708297877638,"msg":"failed to send notification: 8d...46, ResponseError(Response { error: Some(ErrorBody { reason: BadDeviceToken, timestamp: None }), apns_id: Some(\"...\"), code: 400 })"}

We should remove tokens from the database in these cases, but currently we just log the error: https://github.com/deltachat/notifiers/blob/eaf89f8270c6f00c4b39f05de04913e9dd047488/src/notifier.rs#L76-L78